Re: [virtio-dev] Re: [PATCH v8 08/16] packed virtqueues: more efficient virtqueue layout

From
Cornelia Huck <>
Date
2018-02-28T16:09:46+00:00
ID
Thread
Re: [virtio-dev] Re: [PATCH v8 08/16] packed virtqueues: more efficient virtqueue layout
On Wed, 28 Feb 2018 17:20:29 +0200
"Michael S. Tsirkin" <> wrote:

> I agree.  I think I will stop using the bitfields - they seem to
> cause too much confusion. Just
> 
> struct event {
>  	__le16 event_desc; /* bits 0-14: desc_off. 15 - desc_wrap. */
> 	__le16 event_flags; /* bits 0-1: event_flags, 2-15 - reserved */
> };

Looks sensible; but while you're add it, drop the leading underscores
as well? The spec only talks about 'le16' and friends.

[Also, reserved-and-to-be-ignored or reserved-and-must-be-0?]