Next in thread → Next in month →

[PATCH v2] virtio-net: fix virtqueue numbering error

From
System <>
Date
2017-07-17T15:21:00+00:00
ID
Thread
[PATCH v2] virtio-net: fix virtqueue numbering error
On 07/12/2017 11:50 AM, Cornelia Huck wrote:
> receiveq(n) is at position 2(n-1), not 2n. Same error for transmitq(n)
> and controlq.
>
> VIRTIO-161
>
> Signed-off-by: Cornelia Huck <>
> ---
> v1->v2: fix description
>
use 2N for controlq [Stefan]
> ---
>  content.tex | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index d8bde3a..19f84c8 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -3064,9 +3064,9 @@ features.
>  \item[0] receiveq1
>  \item[1] transmitq1
>  \item[\ldots]
> -\item[2N] receiveqN
> -\item[2N+1] transmitqN
> -\item[2N+2] controlq
> +\item[2(N-1)] receiveqN
> +\item[2(N-1)+1] transmitqN
> +\item[2N] controlq
>  \end{description}
>
>
N=1 if VIRTIO_NET_F_MQ is not negotiated, otherwise N is set by
>

Reviewed-by: Halil Pasic <>

I would actually prefer
 +\item[2N-2] receiveqN
 +\item[2N-1] transmitqN
 +\item[2N] controlq
as I don't think we have to spell out  that the n-th tq is
at the index 2n + 1 and the n-th rq is at the index of 2n at all and
especially not in this listing.

But, I'm fine with this too.
Next in thread → Next in month →