Re: [virtio-comment] [PATCH RESEND v6 2/3] content: Document balloon feature page poison

From
Alexander Duyck <>
Date
2020-08-21T21:27:48+00:00
ID
CAKgT0Udx=
Thread
Re: [virtio-comment] [PATCH RESEND v6 2/3] content: Document balloon feature page poison
On Fri, Aug 21, 2020 at 11:24 AM David Hildenbrand <> wrote:
>
> On 18.08.20 19:32, Alexander Duyck wrote:
> > From: Alexander Duyck <>

<snip>

> > +\devicenormative{\paragraph}{Page Poison}{Device Types / Memory Balloon Device / Device Operation / Page Poison}
> > +
> > +Normative statements in this section apply if the
> > +VIRTIO_BALLOON_F_PAGE_POISON feature has been negotiated.
> > +
> > +The device MAY use the content of \field{poison_val} as a hint to guest
> > +behavior.
> > +>>>>>>> patched
>
> ^ looks strange

Yeah, this must have been a merge conflict that didn't get sorted
correctly. I will fix and submit a v7 next week with your
"Reviewed-by" included.

> Apart from that
>
> Reviewed-by: David Hildenbrand <>
>
> Thanks!

Thanks for taking the time to review this. I will push v7 out on
Monday and ask for a vote for inclusion.

- Alex