← Prev in month ← Prev in thread
Next in thread → Next in month →

Suggested improvement for virtq_need_event

From
Olivier Delande <>
Date
2020-07-22T15:28:23+00:00
ID
CANkLV9gVFGJj=wV_jJR4DBfw9xF2ZVVN+fr2qr0A0j==
Thread
Suggested improvement for virtq_need_event
In virtio_queue.h, virtq_need_event is implemented as

  static inline int virtq_need_event(uint16_t event_idx, uint16_t
new_idx, uint16_t old_idx)
  {
      return (uint16_t)(new_idx - event_idx - 1) < (uint16_t)(new_idx
- old_idx);
  }

. Wouldn't the equivalent

  static inline int virtq_need_event(uint16_t event_idx, uint16_t
new_idx, uint16_t old_idx)
  {
      return (uint16_t)(event_idx - old_idx) < (uint16_t)(new_idx - old_idx);
  }

be more readable/intuitive (and possibly slightly faster and more compact)?

Apologies for bikeshedding!
← Prev in month ← Prev in thread
Next in thread → Next in month →