Looks good. A couple of comments from me:
3.2.1 JMS Headers: JMSMessageID / 3.2.1.1 JMSMessageID and JMSCorrelationID Handling
For a request/response pattern where the response queue is fixed, I expect to able to send a message a request queue, then create a consumer on the response queue with a selector that filters for my response e.g.
createConsumer(responseQueue, String.format(“JMSCorrelationID = ‘%s’”, requestMessage.get JMSMessageID()).
If I, as a JMS client library vendor, were to implement the JMS mapping and elect to use message-ids of type message-id-uuid, then I think the application calling get JMSMessageID() would see “ID:AMQP_UUID:<string representation of UUID>”. This would mean the JMS selector produced by the application executing the line above would include the type encoding prefix “ID:AMQP_UUID”. As I assume the type encoding prefixes are private, the selector would then fail to match on the server peer.
What is the rationale in 3.2.1 reading “SHOULD use message-id-string”?
3.3.2 Properties Section: User Id
What is behaviour is required if the user-id is not legal UTF-8?
5.3 Temporary Destinations
The text ought to mention the use of terminus capabilities temporary-queue/temporary topic.
General
There are a number of places where we talk about the need to throw an exception, but don’t actually define what it should be.
From:
[mailto:] On Behalf Of Robert Gemmell
Sent: Wednesday, February 08, 2017 5:50 PM
To:
Subject: [amqp-bindmap] Groups - Advanced Message Queuing Protocol (AMQP)
JMS Mapping Version 1.0 WD07 uploaded
Document Name
:
Advanced Message Queuing Protocol (AMQP)
JMS Mapping Version 1.0 WD07
Description
WD7. The changes since WD6 are around: # AMQPBINDMAP-15: JMSMessageID and JMSCorrelationID handling # AMQPBINDMAP-33: spelling # Updating some TODOs to reflect targeting JMS 2.0 # Fixing copyright year (AMQPBINDMAP-32) and other XSL changes.
The SVN diff since WD6 is available at:
https://tools.oasis-open.org/version-control/browse/wsvn/amqp-bindmap/?op=comp&compare[]=%2F@59&compare[]=%2F@72&manualorder=1
Download Latest Revision
Public Download Link
Submitter
: Mr. Robert Gemmell
Group : OASIS Advanced Message Queuing Protocol (AMQP)
Bindings and Mappings (AMQP-BINDMAP)
TC
Folder : Working Drafts
Date submitted : 2017-02-08 09:49:11
This email is confidential and subject to important disclaimers and conditions including on offers for the purchase or sale of securities, accuracy and completeness of information, viruses, confidentiality, legal privilege, and legal entity disclaimers, available at http://www.jpmorgan.com/pages/disclosures/email
